search

UrDHT / PyUrDHT

Python reference implementation
11 stars 3 forks source link

threadpool.py #67

Closed mmcd closed 9 years ago

mmcd commented 9 years ago

x and t are shadowed from an outer scope.

I am not sure if this is on purpose or not, but it could end up being bad if its accidental.

BrendanBenshoof commented 9 years ago

It is not an issue (I think we could make the error message go away by wrapping it in a function). We assign/allocate both in the local scope, so no values inherited by a higher scope will be read (or modified)