search

UrDHT / PyUrDHT

Python reference implementation
11 stars 3 forks source link

Logic error in join #78

Closed abrosen closed 8 years ago

abrosen commented 8 years ago

Is it just me or will this run only once?

while new_best is None or best_parent.id != new_best.id: #comparison on remoteids?
                    new_best = self.network.seek(self.key,best_parent,self.info.id)
                    found_peers.add(new_best)
                    best_parent = new_best
BrendanBenshoof commented 8 years ago

yep. We need to move the last line of the block up to the top.

abrosen commented 8 years ago

found issue solved in code back in September.