Urala-Communications / the-markets

The Markets nuxt/vue.js app covering crypto, stocks, indices, bonds, currencies and commodities
1 stars 1 forks source link

Live chart issues #3

Open pixelomo opened 3 years ago

pixelomo commented 3 years ago

@9kmmr thanks for your work on live charts, I have merged the code.

There are several issues remaining with the charts that I found while testing:

pixelomo commented 3 years ago

Another minor thing for future reference, as I commented on the PR, please keep class names inline following the current format, on crypto/_symbol the classes should be declared like this: <div class="container d-flex justify-content-around w-50 pt-5 vh-100 text-center">

not like this:

        <div
            class="
                container
                d-flex
                justify-content-around
                w-50
                pt-5
                vh-100
                text-center
            "
        >
pixelomo commented 3 years ago

@9kmmr I have found a number of new issues with the latest code

Testing 1/5/10/30 minutes the chart doesn't update and I see an error GET https://api.thedice.com/api/1m/BTCUSD/1 net::ERR_CERT_DATE_INVALID

Why are you calling the thedice.com/api ?

On Ethereum 3M/6M/1Y all show the same chart

On Currencies, only YTD range is shown on all options, similar issue on Commodities

There is a repeated error in the console from failed prop type in the Price component, we need to update the prop type to expect integers and strings

Vue warn]: Invalid prop: type check failed for prop "price". Expected String with value "15312.63965", got Number with value 15312.63965.

---> <Price> at components/Price.vue
       <NuxtLink>
         <IndexList> at components/IndexList.vue
           <Pages/index.vue> at pages/index.vue
             <Nuxt>
               <Layouts/default.vue> at layouts/default.vue
                 <Root>