Uraneptus / Sullys-Mod

Sully's Mod rewrite [Work in Progress]
https://www.curseforge.com/minecraft/mc-mods/sullys-mobs
GNU Lesser General Public License v3.0
34 stars 14 forks source link

[Enhancement] Grindstone Polishing recipes don't support tags as ingredients. #65

Closed Vaelzan closed 10 months ago

Vaelzan commented 10 months ago

Hey! I was hoping to add some extra recipes to Valhelsia 5 that make use of the Grindstone Polishing mechanic, but it would cut down significantly on the number of recipes if ingredients could be tags, not just limited to item IDs.

Example use case: Biomes o' Plenty and Create both add Rose Quartz. If they both have the same tag (such as forge:gems/rose_quartz) then only one recipe would be needed to allow for both to be polished into Create's Polished Rose Quartz.

Uraneptus commented 10 months ago

Hey, great idea! I have no clue why we haven't done this yet. This will make compat much easier!

Vaelzan commented 10 months ago

Since it would require changing the recipe format a touch, can I please also request that you use the same format as vanilla Minecraft recipe JSON?

Just using an example from within the mod: https://github.com/Uraneptus/Sullys-Mod/blob/1.20.x/src/generated/resources/data/sullysmod/recipes/crafting/rough_jade.json

"result": {
  "count": 9,
  "item": "sullysmod:rough_jade"
}

feels much cleaner than the current recipe format that has a separate resultCount entry, rather than including both the item (or tag) and the count inside the result object.

Edit: This is also to make my life easier when using KubeJS instead of crafting datapacks directly, but I think it'd have benefits to other people in the future, too!

Uraneptus commented 10 months ago

What you described is implemented and will soon be released in a final 1.19.2 update.

Uraneptus commented 10 months ago

I'm really sorry that I didn't answer to your last question btw! I totally forgot. But I added your request as well and the recipe is now in the format of vanilla recipes. Thanks a lot for your enhancement suggestions ^^