Open BZ-BowenZhang opened 3 months ago
I have started looking at this to see if the same RNG seed generates outputs deterministically.
It looks like the scripts up to 3.2.3 are currently deterministic but not for secondary locations with PAM.
Exploring this would also be simplified through implementing #53 first
From discussion with @BZ-BowenZhang and @Hussein-Mahfouz, we'd like to measure three things:
@sgreenbury non determinism in 3.2.3_assign_secondary_zone.py
may be due to the following:
DiscretionaryTripsOD
and DiscretionaryTripsRound
. Thanks @Hussein-Mahfouz for identifying these calling random.choice()
, I think that's it. I've updated the init_rng()
method to include setting the seed for random
too and this now produces deterministic outputs for a given seed. I'll open a PR!
According to the discussion on 7th AUG between @BZ-BowenZhang @sgreenbury and @Hussein-Mahfouz, the difference between the assigning results across each run is needed to test and prove this algorithm's stability. This may involve at least two parts: