search

Urban-Analytics / RAMP-UA

https://urban-analytics.github.io/RAMP-UA/
MIT License
15 stars 10 forks source link

QUANTRampAPI2.py v quant_api.py #268

Closed Sparrow0hawk closed 3 years ago

Sparrow0hawk commented 3 years ago

I'm nit picking through things on documentation and have noticed we have both QUANTRampAPI2.py and quant_api.py.

They both lack tests but also seem broadly to do similar things with quant_api.py simply being a more standard python module.

@nickmalleson are we able to tidy this up and remove QUANTRampAPI2.py from microsim module?

ciupava commented 3 years ago

I don't think that QuantRampAPI2 is actually used.

nickmalleson commented 3 years ago

Indeed, QuantRampAPI2 is a hangover from some old code that Natalie was writing. I have deleted it as part of issue https://github.com/Urban-Analytics/RAMP-UA/issues/267 (in commit d769ee1) . We should write tests for quant_api.py, this is the subject of https://github.com/Urban-Analytics/RAMP-UA/issues/262