Urban-Analytics / RAMP-UA

https://urban-analytics.github.io/RAMP-UA/
MIT License
15 stars 10 forks source link

Scenario notebook #283

Closed nickmalleson closed 3 years ago

nickmalleson commented 3 years ago

This PR integrates the changes that @spoonerf made to the model for the paper. The main addition is the notebook: https://github.com/Urban-Analytics/RAMP-UA/blob/scenario_notebook/experiments/calibration/week_earlier_2021.ipynb as well as a relatively minor addition to allow a healthier population. (I'm not sure what this does, but is off by default)

Once this has been merged we can tag the repo as it represents the state of the model used to create the results.

codecov[bot] commented 3 years ago

Codecov Report

Merging #283 (f4f4dc3) into master (94222f1) will increase coverage by 3.98%. The diff coverage is 96.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #283      +/-   ##
==========================================
+ Coverage   41.80%   45.78%   +3.98%     
==========================================
  Files          23       22       -1     
  Lines        3045     2848     -197     
==========================================
+ Hits         1273     1304      +31     
+ Misses       1772     1544     -228     
Impacted Files Coverage Δ
microsim/opencl/ramp/params.py 98.14% <87.50%> (+0.10%) :arrow_up:
microsim/population_initialisation.py 90.98% <96.15%> (+3.88%) :arrow_up:
microsim/quant_api.py 83.33% <100.00%> (+83.33%) :arrow_up:
microsim/utilities.py 93.22% <100.00%> (+1.06%) :arrow_up:
microsim/r_interface.py 78.26% <0.00%> (+52.17%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 94222f1...f4f4dc3. Read the comment docs.

Sparrow0hawk commented 3 years ago

Couldn't get the experiment notebook working in BinderHub (due to memory limits) but will have a look at providing some configuration for doing it in colab. Happy to approve this once minor comments above are resolved.

nickmalleson commented 3 years ago

@Sparrow0hawk thanks for looking at this, I think I have resolved all conversations unless I have missed soemthing. If you're happy could you merge?