search

Urban-Meteorology-Reading / SUEWS

Surface Urban Energy and Water Balance Scheme
https://suews.readthedocs.io/
Mozilla Public License 2.0
6 stars 15 forks source link

CO2 dev: missing new gsModel implementation? #27

Closed sunt05 closed 5 years ago

sunt05 commented 5 years ago

in the test example file for CO2 and driver.f95, I noticed gsModel=3 and gsModel=4 are used for surface resistance calculation.

https://github.com/Urban-Meteorology-Reading/SUEWS/blob/ac983114c45811942c2b58b288f256db71333cbf/SUEWS-SourceCode/suews_ctrl_driver.f95#L987-L1008

However, related implementations are missing from phys_resist.f95. Have they actually been implemented?

For now, I temporally changed the conductance code to get the new CO2 version running; but this might needs further infestation.

suegrimmond commented 5 years ago

Are Leena and Minttu subscribed to this? Please see issue below that Ting has found.

Best wishes Sue

Prof Sue Grimmond Meteorology, University of Reading

From: Ting Sun notifications@github.com Sent: Sunday, May 26, 2019 8:11:28 AM To: Urban-Meteorology-Reading/SUEWS Cc: Subscribed Subject: [Urban-Meteorology-Reading/SUEWS] CO2 dev: missing new gsModel implementation? (#27)

in the test example file for CO2 and driver.f95, I noticed gsModel=3 and gsModel=4 are used for surface resistance calculation. However, related implementations are missing from phys_resist.f95. Have they actually been implemented?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/Urban-Meteorology-Reading/SUEWS/issues/27?email_source=notifications&email_token=AE2KZXXAVXOWYPR3QQRI6J3PXISZBA5CNFSM4HPV7PDKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GV4CE7A, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AE2KZXXVKVXP77ZS3OEF3KTPXISZBANCNFSM4HPV7PDA.

havum commented 5 years ago

At the moment, I have used gsmodel 3 and 4 only in my CO2 calculations. Subroutine SUEWS_cal_BiogenCO2 in driver.f95 calls SurfaceResistance with 2 meter temperature if gsmodel is 3 or 4. I'm not sure if this is the most ideal way to do it?

sunt05 commented 5 years ago

The problem is, in your current submitted CO2 code, gsmodel options 3 and 4 won't be working as they are not implemented. That's why I raised this issue. I guess you might have implemented them somewhere but didn't incorporate them into the submitted code.

sunt05 commented 5 years ago

See here: https://github.com/Urban-Meteorology-Reading/SUEWS/blob/ac983114c45811942c2b58b288f256db71333cbf/SUEWS-SourceCode/suews_phys_resist.f95#L360-L362

gsModel options other than 1 or 2 would raise runtime errors.

havum commented 5 years ago

I see what you mean now! They were implemented in the version that I send Leena last week. She put the code here in github so we have to ask her about it. If it is ok, I probably can fix this tomorrow.

sunt05 commented 5 years ago

Great, Thanks! Once you push the new to code to test-dev-CO2, it would be good to submit a pull request to merge your branch to test-dev, so we can more easily detect the possible errors with the automatic testing procedures set there.

ljarvi commented 5 years ago

Hi, Latest conductance code now found from the rep.

Leena

-- Leena Järvi (PhD, docent) Associate Professor in Applied Urban Meteorology Institute for Atmospheric and Earth System Research (INAR) / Physics & Helsinki Institute of Sustainability Science (HELSUS) Faculty of Science University of Helsinki Tel: +358 503110371

From: Ting Sun notifications@github.com Reply-To: Urban-Meteorology-Reading/SUEWS reply@reply.github.com Date: Sunday, 26 May 2019 at 10.12 To: Urban-Meteorology-Reading/SUEWS SUEWS@noreply.github.com Cc: "Järvi, Leena J" leena.jarvi@helsinki.fi, Assign assign@noreply.github.com Subject: Re: [Urban-Meteorology-Reading/SUEWS] CO2 dev: missing new gsModel implementation? (#27)

Great, Thanks! Once you push the new to code to test-dev-CO2, it would be good to submit a pull request to merge your branch to test-dev, so we can more easily detect the possible errors with the automatic testing procedures set there.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHubhttps://github.com/Urban-Meteorology-Reading/SUEWS/issues/27?email_source=notifications&email_token=AJNQ6OI2PDMWW6JOIGZ762DPXIZ5BA5CNFSM4HPV7PDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWH72IY#issuecomment-495975715, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AJNQ6ONEQWUEN26X2PSTBA3PXIZ5BANCNFSM4HPV7PDA.

sunt05 commented 5 years ago

Thanks, Leena. I'll incorporate your additions.