search

Urban-Meteorology-Reading / SUEWS

Surface Urban Energy and Water Balance Scheme
https://suews.readthedocs.io/
Mozilla Public License 2.0
6 stars 15 forks source link

LAI issue #7

Closed sunt05 closed 5 years ago

sunt05 commented 5 years ago

@havum please attach the SUEWS files for reproducing your issues here.

havum commented 5 years ago

sample.zip Current code has issues calculating GDD and it affects also LAI. GDD should calculate daily maximum and minimum temperatures and cumulate daytime hours. Now daily GDD values are affected by all the previous days that are modelled. This sample.zip involves input and output from Helsinki that will reproduce this issue.

I have temporarily fixed the issue in suews_phys_dailystate.f95 but I don't know if this is the most sensible way to do it. I will add the code changes later next week to the code repo so that others may help.

havum commented 5 years ago

suews_phys_dailystate.zip

sunt05 commented 5 years ago

Thanks for the update. But what you just did does not follow the git workflow for collaboration, which made me could neither view nor check your changes with the existing code using git. You merely uploaded the code to the issue page, NOT the code repo.

If you really want me to be involved in the collaboration efficiently, please try to google a bit for a short tutorial of GitHub or git workflow which shouldn’t take longer than 30 min but can save others’ tremendous amount of time in the collaboration. Maybe start by having a look at this one: https://guides.github.com/

Or, just go with what you like and ignore the above. I’ll review this sometime later as you mentioned you managed to get a workaround for your case. But do add details in the issue page so people can pick up this issue later. Thanks.

Sent from my iPhone

On 11 Jan 2019, at 11:47, havum notifications@github.com wrote:

suews_phys_dailystate.zip

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

sunt05 commented 5 years ago

fixed by #14

sunt05 commented 5 years ago

Current code has issues calculating GDD and it affects also LAI. GDD should calculate daily maximum and minimum temperatures and cumulate daytime hours. Now daily GDD values are affected by all the previous days that are modelled. This sample.zip involves input and output from Helsinki that will reproduce this issue.

Thanks for locating the issue. Well done, @havum !