search

UrbanAnalyst / dodgr

Distances on Directed Graphs in R
https://urbananalyst.github.io/dodgr/
127 stars 16 forks source link

Fix namespace #205

Closed mpadge closed 1 year ago

mpadge commented 1 year ago

From cran submission attempt:

  • checking S3 generic/method consistency ... NOTE Apparent methods for exported generics not registered: weight_streetnet.SC See section ‘Registering S3 methods’ in the ‘Writing R Extensions’ manual.

That obviously arises because of this line: https://github.com/ATFutures/dodgr/blob/6d0a47723052ba96fbde42e92f315e895ff6e831/R/weight-streetnet.R#L561 which presumes that both .sc and .SC will be appropriately defined. Solution is obviously to define only .sc, and then repeat for .SC with an alias through out .sc.