Closed AlexandraKapp closed 4 years ago
Oh yeah, that's a really good point, and thank you very much for the input. This seems like a perfect solution ... but ... the package does not Import: dplyr
, so those steps would just need to be converted to base-R equivalent statements. It's mostly just about the left_join
, so should be fairly straightforward. Oh, and it actually doesn't even Import: magrittr
, so code must also remain pipe-free. If could update that, I'll be very happy to merge. Thanks!
thanks! oh, maybe I should have run the checks ;) I'll go ahead and update that
now it should work. I'm not quite sure how to make the appveyor check pass, though.
Don't worry about appveyor - that all looks great. Shall merge in a moment
One last request: Could you please add your name as role = "ctb"
to the DESCRIPTION
file? (You don't have to add an ORCID, but feel free to do so if you like). Thanks!
Issue: the function
frequencies_to_stop_times
does not update the trip_ids intrips.txt
andstop_times.txt
. Therefore, the routing withgtfs_route
does not work properly.Routing result before:
With fix: