UrbanAnalyst / gtfsrouter

Routing and analysis engine for GTFS (General Transit Feed Specification) data
https://urbananalyst.github.io/gtfsrouter/
82 stars 17 forks source link

change frequencies_to_stop_times function to allow proper routing #32

Closed AlexandraKapp closed 4 years ago

AlexandraKapp commented 4 years ago

Issue: the function frequencies_to_stop_times does not update the trip_ids in trips.txt and stop_times.txt. Therefore, the routing with gtfs_routedoes not work properly.

Routing result before: grafik

With fix: grafik

mpadge commented 4 years ago

Oh yeah, that's a really good point, and thank you very much for the input. This seems like a perfect solution ... but ... the package does not Import: dplyr, so those steps would just need to be converted to base-R equivalent statements. It's mostly just about the left_join, so should be fairly straightforward. Oh, and it actually doesn't even Import: magrittr, so code must also remain pipe-free. If could update that, I'll be very happy to merge. Thanks!

AlexandraKapp commented 4 years ago

thanks! oh, maybe I should have run the checks ;) I'll go ahead and update that

AlexandraKapp commented 4 years ago

now it should work. I'm not quite sure how to make the appveyor check pass, though.

mpadge commented 4 years ago

Don't worry about appveyor - that all looks great. Shall merge in a moment

mpadge commented 4 years ago

One last request: Could you please add your name as role = "ctb" to the DESCRIPTION file? (You don't have to add an ORCID, but feel free to do so if you like). Thanks!