Closed AlexandraKapp closed 3 years ago
Merging #45 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #45 +/- ##
=======================================
Coverage 92.74% 92.74%
=======================================
Files 15 15
Lines 1226 1226
=======================================
Hits 1137 1137
Misses 89 89
Impacted Files | Coverage Δ | |
---|---|---|
R/timetable.R | 100.00% <ø> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update a0e91c1...9752945. Read the comment docs.
get_timetable(gtfs, date=20200925)
also addcalendar.txt
is scanned for valid entries@mpadge I adjusted the
filter_by_date
function, as I couldnt think of a usecase where the old version would be needed without the inclusion of the "calendar" entries. Though this could lead to different results for people who used the function before and which would now have a different behavior. Therefore I was considering to add a parameter "scan_day_for_date = FALSE" to theget_timetable()
function that is then passed tofilter_by_date.