Closed mpadge closed 3 years ago
hm, both arguments seem valid. 🤔
how about a third option: invert_route_pattern = FALSE
to make it more apparent that the parameter belongs to the route_pattern
within the gtfs_timetable
function?
Good idea, but how about an even better one: That commit just allows a "!" to be put at the start of any route_pattern
argument in order to invert/exclude it.
Currently only works as a positive
grep
match. Should also add aninvert_match = FALSE
parameter that, whenTRUE
, usesgrep(..., invert = TRUE)
to exclude the matched items. What should it be called?invert_match
to match theinvert
parameter ofgrep
itself, which is in turn called that because that just adds the-v
flag to the grep library call which is described as "invert call".exclude_match
because that is perhaps more directly informativeping @AlexandraKapp