UrbanAnalyst / gtfsrouter

Routing and analysis engine for GTFS (General Transit Feed Specification) data
https://urbananalyst.github.io/gtfsrouter/
84 stars 17 forks source link

add traveltimes to vignette #80

Closed AlexandraKapp closed 3 years ago

AlexandraKapp commented 3 years ago

extension of the vignette for the gtfs_traveltimes function. I kept it quite basic. Any additions or futher explanations that should be included?

mpadge commented 3 years ago

Thanks @AlexandraKapp, but please see #55 first - I think this would be much better in it's own separate vignette. Could you please accordingly copy your code across to a new vignette file, and we'll start from there? Thanks!

codecov[bot] commented 3 years ago

Codecov Report

Merging #80 (a3c8d47) into main (b74a2b7) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #80   +/-   ##
=======================================
  Coverage   87.84%   87.84%           
=======================================
  Files          19       19           
  Lines        1826     1826           
=======================================
  Hits         1604     1604           
  Misses        222      222           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b74a2b7...5c29829. Read the comment docs.

mpadge commented 3 years ago

Thanks for putting your name on it. Current version now fails because of new start_time_limits parameter which expects two values, and fails if there is only one, as in current code. Once you've updated that, I'll happily merge.

AlexandraKapp commented 3 years ago

now it should work :) feel free to edit or add content