search

UrbanApps / Armchair

A simple yet powerful App Review Manager for iOS and OSX in Swift
MIT License
1.2k stars 137 forks source link

rateApp() not working, "Write Review" page in AppStore cannot be opened. #109

Closed csemresari closed 7 years ago

csemresari commented 7 years ago

Currently Armchair's rateApp() function is not working.

In order to open the "Write Review" page in AppStore:

1) Use

Armchair.opensInStoreKit(false)

2) Change Armchair's reviewURLString() like below

fileprivate func reviewURLString() -> String {

        let workingReviewURL = "https://itunes.apple.com/us/app/id\(appID)?ls=1&mt=8&action=write-review"
        return workingReviewURL
}
coneybeare commented 7 years ago

Nice find. Please submit a pull request that has this as a backwards compatible value per iOS version. Don't forget about the affiliate code and affiliate campaign values as well.

dagerydoo commented 7 years ago

What is the plan for updating this for iOS 11? @csemresari are you working on a fully backwards compatible change? I noticed this forked change which seems good enough for most of us to proceed. I'd prefer to use a formal release from this repo, but I am concerned that it lacks support for iOS 11 a good while after the update was released...

coneybeare commented 7 years ago

I've updated master with this change, and am pushing cocoapod version 0.3.4 now.