UrbanApps / Armchair

A simple yet powerful App Review Manager for iOS and OSX in Swift
MIT License
1.2k stars 137 forks source link

SPM Support #142

Open check4ismail opened 3 years ago

msmollin commented 3 years ago

Tried to test this on my fork and while the package did successfully import, the resulting module was empty save a single import statement. I'm not a SPM expect but I'm guessing it's because we've marked UrbanApps/Armchair as an upstream dependency which won't import anything unless this repo supported SPM from the get go. (It could also be the target doesn't declare any dependencies. Like I said I'm no expert here).

That said, I don't believe we need to actually depend on anything given this codebase has no dependencies, so I rewrote the Package.swift to not depend on anything over here in my mods branch. These changes do work correctly in my app and everything compiles nicely.

Feel free to uptake these changes in your branch. I kinda flubbed a rebase at one point and so it squashed my changes into your commit accidentally @check4ismail. If you want me to open a PR against your fork I'm happy to do so - just would need to redo my (rather small) changes.