Remind button always shows if remindButtonTitle is set

UrbanApps / Armchair

A simple yet powerful App Review Manager for iOS and OSX in Swift

MIT License

1.2k stars 137 forks source link

Remind button always shows if remindButtonTitle is set #45

Closed JagCesar closed 8 years ago

JagCesar commented 8 years ago

Hey!

Let me start of by thanking you for writing this. Much love.

I ran across a bug and wanted to report it, not sure if I'm missing something. If it's a bug I'll gladly fix it and send a PR.

If daysBeforeReminding is set to zero and remindButtonTitle is set, the remind Button appears in the rate pop up. The bug seems to be in showsRemindButton()

showsRemindButton() should return false if daysBeforeReminding is set to zero.

coneybeare commented 8 years ago

I agree, that looks like an oversight, considering we do a similar check here. I would entertain a pull request fixing it.

JagCesar commented 8 years ago

Sweet. I'm on it.