search

UrbanApps / Armchair

A simple yet powerful App Review Manager for iOS and OSX in Swift
MIT License
1.2k stars 137 forks source link

Created public method to reset counters #51

Closed fotiDim closed 8 years ago

fotiDim commented 8 years ago

Based on #49 I created this PR. This doesn't reset everything in the block you suggested as I only need to reset:

The app version is not changing so I leave userdefault values intact.

coneybeare commented 8 years ago

Thanks, nice work. I'd rather see a public method reset which includes all of the reset values in that block, then calls your resetCounters method as part of it. This would provide the implementor with 2 new options: one to completely reset Armchair in runtime, and one to reset only the counters, as you have done.

fotiDim commented 8 years ago

Done. I took the liberty to rename resetCounters to resetUsageCountersand instead of reset I used resetAllCounters to avoid ambiguity. Using reset might imply that we are reseting Defaults too.

coneybeare commented 8 years ago

Looks good, thanks!