search

UrbanApps / Armchair

A simple yet powerful App Review Manager for iOS and OSX in Swift
MIT License
1.2k stars 137 forks source link

swift 3 #71

Open kapellanos opened 8 years ago

kapellanos commented 8 years ago

any plan to migrate the pod to swift 3 syntax?

coneybeare commented 8 years ago

Can't accept PR's until out of beta

KyleMay commented 8 years ago

Why not have a separate Swift 3 branch until it's out of beta like a lot of other libraries do?

kevinlieser commented 8 years ago

Whats the status?

coneybeare commented 8 years ago

I made the swift3 branch shortly after the above comment, nobody has send me a pull request to it as requested. https://github.com/UrbanApps/Armchair/tree/swift3

bjaskj commented 8 years ago

Status? Need this to work on xcode 8 with carthage.

coneybeare commented 8 years ago

@bjaskj you can see the swift 3 branch here: https://github.com/UrbanApps/Armchair/tree/swift3 feel free to submit a pull request if it is not working for you.

donpironet commented 8 years ago

Can you please update the project to Swift 3 so I can update via carthage?

coneybeare commented 8 years ago

@donpironet There is a swift3 branch you can use here

donpironet commented 8 years ago

Thanks. What do I need to specify to get it via carthage?

EDIT: it can be done via git "https://github.com/UrbanApps/Armchair.git" "swift3"

codytwinton commented 8 years ago

Any update on merging the swift3 branch into master and issuing a release? Especially for Cocoapods?

donpironet commented 8 years ago

+1 for cocoapods request.

jlaws commented 8 years ago

+1

3adel commented 8 years ago

+1

makoni commented 8 years ago

Is there any good alternative? Swift 3.0.1 released and there's still nothing happened

coneybeare commented 8 years ago

I haven't had time to resolve the merge conflicts in the other PR's that update to the swift 3 branch. If somebody wants to submit a PR with the appropriate edits to the master branch, I will take a look and merge if all is good.

andrewschreiber commented 7 years ago

Meanwhile for swift 3 projects, put this in your Podfile:

pod 'Armchair', :git => 'https://github.com/UrbanApps/Armchair.git', :branch => 'swift3'

Works fine with Swift 3.0.1

Jeehut commented 7 years ago

I just wanted to use this library but it seems it's not being maintained any more. @coneybeare clearly lost interest (it's more than half a year after the Swift 3 release and still no native Swift 3 support!) so I'm unstar-ing this and opting for Appirater instead which is written in Objective-C (which I wanted to prevent) but at least it's actively maintained and maps well to Swift.

In the future there will probably be a completely different approach to this issue anyway as Apple has introduced the new in-app review APIs. See the Human Interface Guidelines for it here. We just need to wait until iOS 10.3 is far more distributed amongst users ...