search

UrbanApps / Armchair

A simple yet powerful App Review Manager for iOS and OSX in Swift
MIT License
1.2k stars 137 forks source link

Update code for Review From App using StoreKit (iOS >= 10.3) #99

Closed hardik99 closed 7 years ago

hardik99 commented 7 years ago

Hey ,

Update repository for review using StoreKit added by Apple from iOS >= 10.3

SKStoreReviewController.requestReview()

perteraul commented 7 years ago

+1 on this. It would be awesome.

perteraul commented 7 years ago

@hardik99

I needed this, so I tweaked the Armchair.swift file in order to create a workaround. Here's what works for me, though I'm not sure it's the best practice out there and if it'll work for you.

http://snpy.in/OkQpZF

In the rateApp() function I changed the current if #available(iOS 10.3, *) into else if #available(iOS 10.2, *) and added a new if #available(iOS 10.3, *) { SKStoreReviewController.requestReview() } before the iOS 10.2.

ArturoLee commented 7 years ago

@perteraul Nice work. I thought it was weird this library didn't have that. Can you do a pull request?

ari3l commented 7 years ago

This is already implemented

To use the new iOS 10.3 prompt simply do: Armchair.useStoreKitReviewPrompt(true)

Perhaps this should be added to the docs.

ArturoLee commented 7 years ago

@ari3l You're right. This issue should be closed. And documentation would be helpful

hardik99 commented 7 years ago

Great. It will be very helpful. Thanks.