search

UrbanApps / UAAppReviewManager

UAAppReviewManager is a simple and lightweight App review prompting tool for iOS and Mac App Store apps. It's Appirater all grown up, ready for primetime.
MIT License
801 stars 117 forks source link

Affiliate Campaign Code URL causes EXC_BAD_ACCESS #23

Open aefreedman opened 10 years ago

aefreedman commented 10 years ago

occurs on line #1017 in reviewURLString()

reviewURL = [reviewURL stringByReplacingOccurrencesOfString:@"AFFILIATE_CAMPAIGN_CODE" withString:[NSString stringWithFormat:@"%@", self.affiliateCampaignCode]];

self.affiliateCampaignCode is pointing to a junk memory address, despite being set properly prior to calling reviewURLString()

I was using your default values for Affiliate and Campaign codes.

coneybeare commented 10 years ago

Can you produce a sample project showing it in action? This isn't happening in the example project.

aefreedman commented 10 years ago

I'll see if I can. The line was causing a crash in a live App. The reviewURL without the campaign code is fine, but I haven't had enough time to look through it completely yet.

coneybeare commented 10 years ago

It is possible it may be happening inside UAAppReviewManager, but this is the first I have ever heard of the problem, so it may be something else acting awry here. We can see hundreds of other apps sending the default affiliate campaign codes so I suspect it may be the latter, but please do let me know if you see otherwise and we will patch it up.

coneybeare commented 10 years ago

Actually, can you give us your app id and I will see if you have anybody sending it at all? It may not be a problem affecting all of your users, which would provide an extra data point.

aefreedman commented 10 years ago

932468632

coneybeare commented 10 years ago

Good news is that we have no reports about that id yet, so whatever is causing the memory clobbering should be 100% reproducible. The attribute in question is strongly retained so there really should't be an issue within the framework itself. Check the integration you have, whether or not you have arc enabled or not, any other frameworks in your app which work with memory on a lower level.

aefreedman commented 10 years ago

Cool, thanks. I'll keep looking into it.