search

UrbanCCD-UChicago / plenario2

The Premier Open Data Discovery Platform
http://plenar.io/
Other
12 stars 2 forks source link

Phoenix development server logging is excessively verbose #444

Closed brlodi closed 6 years ago

brlodi commented 6 years ago

The amount of debug logging we're currently having Phoenix dump to the terminal is insane, to the point of grinding my terminal emulator to a halt and making it literally impossible to learn anything meaningful from it. Unless someone on the team is secretly Cypher from the ~original~ only Matrix movie and can see through the code, this isn't serving a useful purpose since it completely fills any reasonable scroll back buffer every time the server ingests something.

We should change the default logging level to something higher, and optionally expose a command line parameter to enable verbose logging for when it is desired.

brlodi commented 6 years ago

(The labels might be overly broad, but all four domains are contributing to the console spam. Feel free to remove some.)

vforgione commented 6 years ago

I can't even begin to tell you how much I rely on the debug output during local development. It's probably annoying for you since you're not on the back end as much, but this is truly critical for me.

brlodi commented 6 years ago

I'm not suggesting the existence of debug output is somehow fundamentally incorrect, but when a single AoT ingest (which happens somewhat at random depending on how you're starting and stopping the Phoenix server) maxes out terminal performance and vastly overflows a reasonably-sized scroll back buffer it's literally shooting itself in the foot. That flood could easily be disguising other issues, even ETL ones, by shoving them up and out of view faster than any human could possibly read.

On a more selfish note, I just literally can't do my own work without opening mix.exs and changing the logging level to at least info. It's not a matter of it being annoying, but that there is a ~65% chance any time I restart the server that the Webpack output at the beginning gets instantly obliterated.

The default log level should be [info], with [debug] available behind a flag or by tailing a log file somewhere.