search

UrbanInstitute / education-data-package-stata

MIT License
19 stars 4 forks source link

Quotes in options #19

Closed mchingos closed 6 years ago

mchingos commented 6 years ago

Are the quotes necessary in the options? I just tested both sub(.) and col(.) without the quotes and it worked fine, but perhaps there are cases where it is necessary?

grahamimac commented 6 years ago

Good eye. I had to look this up in the documentation (which is 1,005 pages!) for mata, and you are correct, there is no need for the quotes. I can't immediately see why they might be necessary, but I will test and see what I think. If not, we will update the instructions and examples in the next release. Thanks Matt!

grahamimac commented 6 years ago

Ok, quotes removed from the subset and columns options in the documentation, which you'll see updated in the next release Friday. I haven't found any ill effects yet, but we can monitor this.