Closed VivianSihanZHENG closed 4 years ago
Ok, when reviewing, I tested on
educationdata using "school ccd directory", sub(year=2018) clear
in a local directory. Two oddities stood out:
ncessch_num
is all missing values. It's a long with%20.0g
formatting, but doesn't appear. Any idea why this is the case?latitude
andlongitude
only have 2 digits after the decimal point as stored in the API, but I would expect these to have more (at least 6). Why are these missing?
Hi Graham,
Thanks for flagging them, and sorry about the confusions here! I think these issues already exist in the current version of the Stata package or API.
For 1, this is a separate issue in the current version of the package, and has been in my list to resolve. The issue was documented here: https://github.com/UrbanInstitute/education-data-package-stata/issues/57.
For 2, the 2-digit lat/lon are consistent with what's currently in the API (https://educationdata.urban.org/api/v1/schools/ccd/directory/2018/). This is another separate issue, where the float
data type in MySQL automatically round the float variables. We already figured out the solution, and are about to fix it in production in this upcoming release. And data in staging has been fixed (e.g., https://educationdata-stg.urban.org/api/v1/schools/ccd/directory/2018/).
Please let me know if you have any questions, or see anything else.
Vivian
Thanks Vivian. Looks good. Perhaps add a sentence to the sthlp file that says something like: "Using the cache option may increase the speed of the program if you or others have made similar requests recently."
Great thanks Graham! It was added in the help file.
When doing
label values
for float variables, addnofix
option to prevent display formats from being widened.