UrielCh / opencv4nodejs

ESM Nodejs bindings to OpenCV 3/4
MIT License
254 stars 51 forks source link

Allow passing cap to VideoCapture constructor #157

Closed la-we closed 2 months ago

la-we commented 3 months ago

Currently working on a project where i need functionality of passing explicit CAPs to VideoCapture, figured i contribute a little.

UrielCh commented 3 months ago

Please try to match parameters names from openCV:

VideoCapture(const String &filename, int apiPreference=[CAP_ANY])

Opens a video file or a capturing device or an IP video stream for video capturing with API Preference.

the parametere is named apiPreference, not cap

UrielCh commented 3 months ago

I live you check why some CI task fail. https://github.com/UrielCh/opencv4nodejs/actions/runs/10590201924/job/29348071635

la-we commented 3 months ago

Tests should pass now on all OSes

UrielCh commented 2 months ago

the test still failed on macos.

UrielCh commented 2 months ago

LGTM