search

Urigo / angular-spinkit

SpinKit (http://tobiasahlin.com/spinkit/) spinners for AngularJS
MIT License
189 stars 36 forks source link

Update the README.md and the ngSpinkitImagePreloader module #16

Closed dmhts closed 10 years ago

dmhts commented 10 years ago
  1. I've updated the paragraph 1 in the README.md. I believe it will be helpful for users to install your component and update the bower.json using the only one command. Also popular projects do this in the same way (angular-ui/ui-router, angular-ui/bootstrap, grevory/angular-local-storage and etc).
  2. I've also updated the spinkitImagePreloader a little bit. Just added the spinkit-image-preloader-class attribute in order to have ability configure the spinner-wrapper css-class. I also mentioned this feature in the readme.
dmhts commented 10 years ago

Also I think it would be reasonable to update "keywords" field in bower.json like this:

"keywords": [
    ...
    "image preloader",
    "image spinner",
    "etc ..."
]

And update "dependencies" field

"dependencies": {
    "angularjs": "*"
}
Urigo commented 10 years ago

@dmgts that is a good idea, can you update it, that way you will get the credit?

dmhts commented 10 years ago

Kind of... It gives you more chances to be found here - http://bower.io/search/