Urigo / graphql-modules

Enterprise Grade Tooling For Your GraphQL Server
https://graphql-modules.com/
MIT License
1.3k stars 114 forks source link

fix: use graphql utilties for more reliable check for class types #2478

Open justin-equi opened 10 months ago

justin-equi commented 10 months ago

Description

It is possible for multiple versions of the graphql module to exist which causes the instanceof checks to fail. This PR uses the utilites from graphql to check instead, which under the covers uses string compare

Fixes # 2477

Type of change

Please delete options that are not relevant.

Screenshots/Sandbox (if appropriate/relevant):

Adding links to sandbox or providing screenshots can help us understand more about this PR and take action on it as appropriate

How Has This Been Tested?

Ran the tests.

Checklist:

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

changeset-bot[bot] commented 10 months ago

⚠️ No Changeset found

Latest commit: 9a96ff9667a38dc2578e17dffabc89ee0eac705a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR