Urigo / meteor-angular-socially

angular-meteor example and tutorial app
https://www.angular-meteor.com/tutorials/socially/angular1/bootstrapping
155 stars 144 forks source link

No display at the end of step3 angular 1 #112

Closed msameeh closed 8 years ago

msameeh commented 8 years ago

I first followed the tutorial, and at the end of step 3 there seems to be no display. Then I downloaded the zip, also tried cloning the step from git. Same results.

Am I missing something?

msameeh commented 8 years ago

Seems to be an issue with urigo:static-templates. Reverting back to angular-templates fixes the issue. Using angular-templates for now...

watalberto commented 8 years ago

I have the same issue, applying the same solution for the moment.

@Kak3n, What you're watching is the content that you have in you index.html or whatever is the name you used for you file which is inside the folder "/client", isn't?

The issue is that code should be replaced by the content of the componen view but it's not working, although if you add a console.log after import the template in the component controller, it seems like works, so the problem is not in when import, it's when try to replace one content to other, at least for me.

jmichalek132 commented 8 years ago

Yes exactly @watalberto It's strange because console.log(template) works as expected. asdasd

watalberto commented 8 years ago

Yes! I hope @Urigo can find the problem better than us! It works with angular-templates but I'd like to see it working with the urigo:static-templates, not only because the tutorial is made using it, its way to include is better for me, it's more difficult to make an error when importing.

jmichalek132 commented 8 years ago

@watalberto would you mind comming to gitter I would like to ask you few questions :smile: ( https://gitter.im/Urigo/angular-meteor )

watalberto commented 8 years ago

@Kak3n sure, I'm already in so shoot your questions, I'd try to help! If we found the solution we'll add it here 👍

mandakhsw commented 8 years ago

Same issue, console.log(template) works fine. @watalberto looking forward your resolution.

kamilkisiela commented 8 years ago

I'm looking into it right now :+1:

kamilkisiela commented 8 years ago

Attributes from body are not being set by urigo:static-templates. Expect the fix soon!

kamilkisiela commented 8 years ago

@watalberto @mandakhsw @Kak3n @msameeh

It should be fixed by the next release of urigo:static-templates, expect it to be published very soon :+1:


Little explanation because I see you guys are really interested in this!

It's not a problem of Socially app by itself. urigo:static-templates in the current state doesn't support attributes on body element. Since they were missing, ng-app was missing too, so the main module which is socially couldn't be bootstraped.


To sum it up. You don't have to change anything inside Socially, only update urigo:static-templates (I will notify you when the next version with the fix will be released!) to the latest version.

watalberto commented 8 years ago

@kamilkisiela Perfect. Yes we guessed it wasn't a problem of Socially app by itself because it works with angular-templates. I will go back to use urigo:static-templates when published.

Many thanks!

msameeh commented 8 years ago

@kamilkisiela Thank you, I too prefer the static-templates option.

Urigo commented 8 years ago

just publish the new changes of @kamilkisiela the issue should be solved now

watalberto commented 8 years ago

@kamilkisiela and @Urigo just re-add the package, I get the new version: urigo:static-templates 0.0.3 but it still doesn't work for me 👎 Gonna donwload the .zip from tutorial and test it, just to make sure I don't have a different problem on my project.

EDITED: To confirm, the project downloaded, after instal node modules and update the meteor packages doesn't work.

kamilkisiela commented 8 years ago

@watalberto

Could you send me .meteor/versions?

watalberto commented 8 years ago

@kamilkisiela sure: MacBook-Pro-de-alberto:meteor-angular-socially-step_03 alberto$ meteor list

autopublish 1.0.7 (For prototyping only) Publish the entire database to ... es5-shim 4.5.10 Shims and polyfills to improve ECMAScript 5 support insecure 1.0.7 (For prototyping only) Allow all database writes from ... jquery 1.11.8 Manipulate the DOM using CSS selectors meteor-base 1.0.4 Packages that every Meteor app needs mobile-experience 1.0.4 Packages for a great mobile user experience mongo 1.1.7 Adaptor for using MongoDB and Minimongo over DDP pbastowski:angular-babel 1.3.4 Babel compiler and ng-annotate for Meteor 1.3 reactive-var 1.0.9 Reactive variable standard-minifier-css 1.0.6 Standard css minifier used with Meteor apps by default. standard-minifier-js 1.0.6 Standard javascript minifiers used with Meteor apps by... tracker 1.0.13 Dependency tracker to allow reactive callbacks urigo:static-templates 0.0.3 Meteor plugin for importing static HTML templates

kamilkisiela commented 8 years ago

@watalberto 0.0.4 should fix it!

Pls check and give me :+1: or :-1:

watalberto commented 8 years ago

Awesome! Now it works!:smiley:

iqzpower commented 8 years ago

Downloaded the zip with the urigo version 0.1.0 and dont work