Uriopass / Egregoria

3D City Builder without a grid
http://douady.paris/blog/
GNU General Public License v3.0
1.48k stars 50 forks source link

Trains #110

Closed Groneschild closed 2 weeks ago

Groneschild commented 3 weeks ago

I Wasn't planning on making a pr, but here I am.

The first thing i did, was making a tool to make straight road connections. It looks better for both rail and highway infrastructure. I would like to enforce something like this for realistic looking rail.

The second thing are custom trains. The toolbox contains a train editor. Trains consist of rolling-stock. Anyone can add rolling-stock in base_mod/rollingstock.lua. I would like a similar thing for road vehicles.

Give me some help with the GUI related programming.

CLAassistant commented 3 weeks ago

CLA assistant check
All committers have signed the CLA.

Uriopass commented 3 weeks ago

Thank you for this (big!) contribution. I'm away for a week or so but I'll make sure to review when I come back!

Uriopass commented 2 weeks ago

Hey so I finally got to review. The code looks good but I have a bit of feedback about the UI. I guess it can probably be improved later on as yakui can take a bit of time to learn.

Anyway all of these aren't blockers, the game is still in development after all and all these can be fixed later on. Still a good foundation! I'm going to merge this.