search

Uriopass / Egregoria

3D City Builder without a grid
http://douady.paris/blog/
GNU General Public License v3.0
1.49k stars 51 forks source link

Fix some warnings #47

Closed ghost closed 2 years ago

Uriopass commented 2 years ago

Did you derive Debug on most structs and Copy on any struct that could be copy ? I'm not a fan of the approach. First, I value compile time and I think debug derived are not free, and I don't see the point of deriving it if it's not used. Second, I don't like deriving Copy on big structs (like Config) so that I don't accidentally copy them which can be expensive sometimes. Can you explain your reasoning?

ghost commented 2 years ago

I can remove them if you prefer. Was just following some lints.

Uriopass commented 2 years ago

Not a fan of missing_debug and missing_copy, I wonder what's the reasoning behind it.

Uriopass commented 2 years ago

Well, looks like the only lint left that applied is explicit anonymous lifetimes, which I don't necessarily agree with, but if it's the rust 2018 idiom then fine I guess. Thanks for the PR, glad you're interested in the project !