Uriopass / Egregoria

3D City Builder without a grid
http://douady.paris/blog/
GNU General Public License v3.0
1.48k stars 50 forks source link

fixes two errors preventing repo from building w/default instructions #61

Closed pracplayopen closed 1 year ago

pracplayopen commented 1 year ago

(build also presently in errored state on github CI status badge).

this appears to be at least in part because of a recent commit (~5d) that changed versioning from using a cargo to a file.

the other error i'm not sure how/when it was introduced, i used rust's suggested fix.

here are errors to go along w/patches that fix them. after applying, project builds and runs game as it's described on README.

   Compiling wgpu_engine v0.1.0 (/home/pracplayopen/work/src/Egregoria/wgpu_engine)
error[E0027]: pattern does not mention fields `ext_buy`, `ext_sell`
   --> egregoria/src/economy/market.rs:159:17
    |
159 |               let SingleMarket {
    |  _________________^
160 | |                 buy_orders,
161 | |                 sell_orders,
162 | |                 capital,
163 | |             } = market;
    | |_____________^ missing fields `ext_buy`, `ext_sell`
    |
help: include the missing fields in the pattern
    |
162 |                 capital, ext_buy, ext_sell } = market;
    |                        ~~~~~~~~~~~~~~~~~~~~~
help: if you don't care about these missing fields, you can explicitly ignore them
    |
162 |                 capital, .. } = market;
    |                        ~~~~~~

For more information about this error, try `rustc --explain E0027`.
error: could not compile `egregoria` due to previous error

------------------------------

   Compiling egregoria v0.1.0 (/home/pracplayopen/work/src/Egregoria/egregoria)
   Compiling native_app v0.4.3 (/home/pracplayopen/work/src/Egregoria/native_app)
error[E0433]: failed to resolve: use of undeclared crate or module `goria_version`
  --> native_app/src/context.rs:54:49
   |
54 |             .with_title(format!("Egregoria {}", goria_version::VERSION))
   |                                                 ^^^^^^^^^^^^^ use of undeclared crate or module `goria_version`

For more information about this error, try `rustc --explain E0433`.
error: could not compile `native_app` due to previous error
Uriopass commented 1 year ago

Oh yeah that was totally a work in progress, I should've pushed it to another branch. Thanks for catching this.

pracplayopen commented 1 year ago

no worries it happens.

impressive project, you really have built one of the better true 3d open city simulators AND in a short time. well done.

small bit of feedback:

none of this seemed too far off, but might benefit from tweaking a couple of defaults and a gregoria-wiki-guide doc as far as playing. that would help people contribute better PRs than this one too. ;)

Uriopass commented 1 year ago

it appears you could 'import paris' and/or create blank grids of varying sizes, the defaults seemed more for edge-level performance testing than actually playing the game

Oh yeah this is definitely just for performance testing, I should put this in the debug menu.

tweaking a couple of defaults

What defaults are you thinking of ?

a gregoria-wiki-guide doc

Yeah this is definitely a good idea! Although the problem is that there is not much to do in the game at the moment really, there's no real gameplay loop because there's not much happening after you put the things down. I plan on changing things but I'm still thinking about how to structure the game economy.

I can definitely add a wiki for a quick introduction, as a player I know I don't really like reading wikis but it should definitely help gather some interest and help create a community if people can actually use the product.

impressive project, you really have built one of the better true 3d open city simulators AND in a short time. well done.

Thanks a lot, this is very kind compliment and helps to boost my motivation.

Also note that currently the UI/UX is quite poor as I didn't really optimize for it. It can definitely get much better but it's very hard work especially since you need player feedback (or I need to playtest it more often, but since I'm used to the current UI it's hard) to improve it.