Urtgard / WQAchievements

9 stars 8 forks source link

11.0.5 New Issue #168

Open Hyphie24 opened 2 days ago

Hyphie24 commented 2 days ago

I'm trying to zero in what's causing it, but putting here for Author to see/look as well

21x bad argument #1 to '?' (Usage: local info = C_QuestLog.GetQuestTagInfo(questID))
[string "=[C]"]: ?
[string "@WQAchievements/WQAchievements.lua"]:1011: in function `Reward'
[string "@WQAchievements/WQAchievements.lua"]:285: in function `CreateQuestList'
[string "@WQAchievements/WQAchievements.lua"]:529: in function `?'
[string "@BattlePetCompletionist/Libs/AceTimer-3.0-17/AceTimer-3.0.lua"]:55: in function <...ePetCompletionist/Libs/AceTimer-3.0/AceTimer-3.0.lua:50>

Locals:
(*temporary) = "bad argument #1 to '?' (Usage: local info = C_QuestLog.GetQuestTagInfo(questID))"

May have already found the fix, but in case there's more

fraerie commented 2 days ago

also getting this issue

2x bad argument #1 to '?' (Usage: local info = C_QuestLog.GetQuestTagInfo(questID))

[string "@WQAchievements/WQAchievements.lua"]:936: in function Reward' [string "@WQAchievements/WQAchievements.lua"]:289: in functionCreateQuestList' [string "@WQAchievements/WQAchievements.lua"]:454: in function `?' [string "@Ace3/AceTimer-3.0-17/AceTimer-3.0.lua"]:55: in function <Ace3/AceTimer-3.0/AceTimer-3.0.lua:50>

Locals: (*temporary) = "bad argument #1 to '?' (Usage: local info = C_QuestLog.GetQuestTagInfo(questID))"

I did a replace all of questId to questID in the WQAchievements.lua file based on the fix posted above and now I get

2x WQAchievements/WQAchievements.lua:1132: attempt to call method 'GetExpansionByquestID' (a nil value) [string "@WQAchievements/WQAchievements.lua"]:1132: in function CheckReward' [string "@WQAchievements/WQAchievements.lua"]:1095: in functionCheckItems' [string "@WQAchievements/WQAchievements.lua"]:1702: in function EmissaryReward' [string "@WQAchievements/WQAchievements.lua"]:290: in functionCreateQuestList' [string "@WQAchievements/WQAchievements.lua"]:454: in function `?' [string "@Ace3/AceTimer-3.0-17/AceTimer-3.0.lua"]:55: in function <Ace3/AceTimer-3.0/AceTimer-3.0.lua:50>

Locals: self =

{ modules =
{ } debug = false Rewards =
{ } questPinMapList =
{ } itemList =
{ } ExpansionList =
{ } missionList =
{ } data =
{ } EmissaryQuestIDList =
{ } db =
{ } rewards = false questPinList =
{ } optionsFrame = Frame { } first = false name = "WQAchievements" L =
{ } baseName = "WQAchievements" defaultModuleState = true questList =
{ } ZoneIDList =
{ } playerName = "Felinae-Aman'Thul" faction = "Alliance" defaultModuleLibraries =
{ } event = Frame { } emissaryRewards = false timer =
{ } orderedModules =
{ } start = 730965.139000 watched =
{ } watchedMissions =
{ } enabledState = true links =
{ } Criterias =
{ } Achievements =
{ } questFlagList =
{ } } questID = 48641 isEmissary = true rewardIndex = 1 retry = false itemName = "Legionfall Spoils" itemTexture = 1519426 quantity = 1 quality = 3 isUsable = true itemID = 157830 itemLink = "|cff0070dd|Hitem:157830::::::::80:102::11:1:3524::::::|h[Legionfall Spoils]|h|r" itemName = "Legionfall Spoils" _ = "|cff0070dd|Hitem:157830::::::::80:102::11:1:3524::::::|h[Legionfall Spoils]|h|r" itemRarity = 3 itemLevel = 45 itemMinLevel = 0 itemType = "Miscellaneous" itemSubType = "Other" itemStackCount = 1 itemEquipLoc = "INVTYPE_NON_EQUIP_IGNORE" itemTexture = 1519426 itemSellPrice = 0 itemClassID = 15 itemSubClassID = 4 (temporary) = nil (temporary) =
{ modules =
{ } debug = false Rewards =
{ } questPinMapList =
{ } itemList =
{ } ExpansionList =
{ } missionList =
{ } data =
{ } EmissaryQuestIDList =
{ } db =
{ } rewards = false questPinList =
{ } optionsFrame = Frame { } first = false name = "WQAchievements" L =
{ } baseName = "WQAchievements" defaultModuleState = true questList =
{ } ZoneIDList =
{ } playerName = "Felinae-Aman'Thul" faction = "Alliance" defaultModuleLibraries =
{ } event = Frame { } emissaryRewards = false timer =
{ } orderedModules =
{ } start = 730965.139000 watched =
{ } watchedMissions =
{ } enabledState = true links =
{ } Criterias =
{ } Achievements =
{ } questFlagList =
{ } } (temporary) = 48641 (temporary) = "attempt to call method 'GetExpansionByquestID' (a nil value)" inspectScantip = WorldQuestListInspectScanningTooltip { processingInfo =
{ } infoList =
{ } updateTooltipTimer = 0.200000 StatusBar = WorldQuestListInspectScanningTooltipStatusBar { } TextRight1 = WorldQuestListInspectScanningTooltipTextRight1 { } supportsDataRefresh = true textRight1Font = "GameTooltipHeaderText" BottomOverlay = Texture { } NineSlice = Frame { } textLeft1Font = "GameTooltipHeaderText" textRight2Font = "GameTooltipText" TopOverlay = Texture { } layoutType = "TooltipDefaultLayout" TextLeft1 = WorldQuestListInspectScanningTooltipTextLeft1 { } textLeft2Font = "GameTooltipText" TextRight2 = WorldQuestListInspectScanningTooltipTextRight2 { } TextLeft2 = WorldQuestListInspectScanningTooltipTextLeft2 { } } EquipLocToSlot1 =
{ INVTYPE_RANGEDRIGHT = 16 INVTYPE_SHIELD = 17 INVTYPE_WEAPONOFFHAND = 17 INVTYPE_RANGED = 16 INVTYPE_WEAPON = 16 INVTYPE_2HWEAPON = 16 INVTYPE_WRIST = 9 INVTYPE_TRINKET = 13 INVTYPE_NECK = 2 INVTYPE_CLOAK = 15 INVTYPE_BODY = 4 INVTYPE_HEAD = 1 INVTYPE_FEET = 8 INVTYPE_TABARD = 19 INVTYPE_HOLDABLE = 17 INVTYPE_FINGER = 11 INVTYPE_WEAPONMAINHAND = 16 INVTYPE_HAND = 10 INVTYPE_WAIST = 6 INVTYPE_LEGS = 7 INVTYPE_SHOULDER = 3 INVTYPE_ROBE = 5 INVTYPE_CHEST = 5 } EquipLocToSlot2 =
{ INVTYPE_FINGER = 12 INVTYPE_WEAPON = 17 INVTYPE_TRINKET = 14 } weaponCache =
{ 165871 = true 165867 = true 165872 = true 165863 = true } armorCache =
{ 165864 = true 165868 = true 165869 = tr

Hyphie24 commented 2 days ago

I'm not getting the 2nd error, what did you do to have it pop?

Oh wait, I might know why, try Beta version, then the QuestID changes, author did code changes for Special Assignment triggers https://www.curseforge.com/wow/addons/wqachievements/files/5762643 (or download the zip from my pull)

fraerie commented 2 days ago

I'm not getting the 2nd error, what did you do to have it pop?

Log in :(

Oh wait, I might know why, try Beta version, then the QuestID changes, author did code changes for Special Assignment triggers https://www.curseforge.com/wow/addons/wqachievements/files/5762643 (or download the zip from my pull)

Do you still neet to do the questID fix?

Hyphie24 commented 2 days ago

yes, until it's pulled from here and pushed to Curse

fraerie commented 2 days ago

ok - that worked!

Machou commented 1 day ago

I used the bêta, and i have this error:

Date: 2024-10-23 11:27:45
ID: 1
Error occured in: Global
Count: 1
Message: bad argument #1 to '?' (Usage: local info = C_QuestLog.GetQuestTagInfo(questID))
Debug:
   [string "=[C]"]: ?
   [string "@Interface/AddOns/WQAchievements/WQAchievements.lua"]:936: Reward()
   [string "@Interface/AddOns/WQAchievements/WQAchievements.lua"]:289: CreateQuestList()
   [string "@Interface/AddOns/WQAchievements/WQAchievements.lua"]:454: ?()
   [string "@Interface/AddOns/Details/Libs/AceTimer-3.0/AceTimer-3.0.lua"]:55:
      ...ce/AddOns/Details/Libs/AceTimer-3.0/AceTimer-3.0.lua:50
Locals:
(*temporary) = "bad argument #1 to '?' (Usage: local info = C_QuestLog.GetQuestTagInfo(questID))"

edit: fix by https://github.com/Urtgard/WQAchievements/pull/169