search

Urthen / case-sensitive-paths-webpack-plugin

Enforces case sensitive paths in Webpack requires.
MIT License
428 stars 45 forks source link

Fix for #40 #41

Closed kirill-konshin closed 4 years ago

Urthen commented 5 years ago

Thanks, once I get some time I'll take a look.

Did you determine if this works in older versions of Webpack as well?

kirill-konshin commented 5 years ago

I'm not sure, most likely for safety it makes sense to do feature detection here.

zackify commented 5 years ago

Maybe a simple if( data.resource) do it the old way?

kirill-konshin commented 5 years ago

Yes, it should be enough

kirill-konshin commented 5 years ago

There's a separate issue regarding done(null, data) -> done(null). Also on a side note I think it's perfectly fine to release a new major version that will support webpack@5+ only.

zackify commented 5 years ago

You can actually use the same check for the done part. It has access to data right there

kirill-konshin commented 5 years ago

I've added ifs

khayyamsaleem commented 4 years ago

any update for this PR?