search

Urucas / electron-packager-interactive

An interactive implementation of electron-packager
MIT License
202 stars 32 forks source link

tidied, semi-colons, interpolated strings & grunt < grunt-cli #2

Closed davemackintosh closed 8 years ago

davemackintosh commented 8 years ago

Tidied up the code, ES6 doesn't have to be let and () =. {}-ed everywhere :smile_cat:
Removed semi-colons, honestly they're not needed :hear_no_evil:
Use interpolated strings instead of whole packages for clarity, no idea what that lib was doing. :confounded:
Fixed a common mistake with grunt and grunt-cli packages. :performing_arts:

davemackintosh commented 8 years ago

There we go, updated to path.join and updated some style issues. Was lots of ' and " in use, standardised to " double-quotes

vrunoa commented 8 years ago

Cool @davemackintosh . Sorry I didn't ask this for you before, can you squash the commits into one and update the package version ?

davemackintosh commented 8 years ago

Squashed

vrunoa commented 8 years ago

Cool :+1: . Merged. I'll publish into npm in a couple of minutes.

davemackintosh commented 8 years ago

Awesome, thanks dude :) Glad to help!

vrunoa commented 8 years ago

Help is always welcome!