Closed adam-lynch closed 8 years ago
When hitting enter on Inquirer, it goes to the next question without selecting any platform or arch.Perhaps, the best solution would be to select a platform and arch by default. I'm thinking, maybe, use the current platform, arch where you're running epi
@vrunoa it's definitely possible to have inquirer not do that. I've done it myself.
Just checked... you use checkbox, that should be list
. I can sort it in a PR?
@adam-lynch PR's are welcome.
@adam-lynch exactly. Maybe some user just want to build for windows and mac avoiding linux, or any combination that just includes 2 platforms. Setting the input to a list type would remove this flow from the module. I believe the best solution for this case would be set the user platform(arch) as default. Also add a validation, throw an error when platform or arch os not selected. Let me know if you would like to implement this, otherwise I'll add this implementation.
@adam-lynch I decided that if a user doesnt select an arch or a platform, it will ask again.
I also had this issue and as a workaround, the lines that specify the platform and architecture in the dist/index.js file can be modified like:
options.arch = "x64";
if (options.arch == "") {
error("Error: Must specify arch");
}
options.platform = "darwin"
if (options.platform == "") {
error("Error: Must specify platform");
}
If I hit enter to select a platform and then arch, I get the following:
If I press space to check a selection then enter to move on to the next question, it works.
Latest version, on a Mac.