search

Urucas / electron-packager-interactive

An interactive implementation of electron-packager
MIT License
201 stars 32 forks source link

Building for darwin ia32 silently fails #7

Closed adam-lynch closed 8 years ago

adam-lynch commented 8 years ago

It says it's successful. I think the bug is not showing an error / allowing the arch choice.

vrunoa commented 8 years ago

@adam-lynch it fails to create the final app ? Does it start building ?

adam-lynch commented 8 years ago

It shows the success message but where the output directory should be, it's just an empty string.

vrunoa commented 8 years ago

@adam-lynch maybe there's a problem with the input folder. Can you give me a log output I can check on ?

antoinepairet commented 8 years ago

electron-packager which is used under the hood does not support ia32 arch for OSX. Running electron-packager . yourApp --platform=darwin --arch=ia32 will do nothing. No warning will be logged.

Conclusion: it is not an issue with electron-packager-interactive itself but with electron-packager A warning would be welcome :-). Can be done here or in electron-packager

vrunoa commented 8 years ago

cool @antoinepairet , didn't know about this. I'll add a warning message in case electron-packager module don't add it.

vrunoa commented 8 years ago

Done. There's a warning to the user that building for darwin ia32 will fail.

https://github.com/Urucas/electron-packager-interactive/blob/master/lib/index.js#L133-L141