search

Urucas / electron-packager-interactive

An interactive implementation of electron-packager
MIT License
201 stars 32 forks source link

Enter now selects arch & platform #8

Closed adam-lynch closed 8 years ago

adam-lynch commented 8 years ago

Fixes #6

adam-lynch commented 8 years ago

@vrunoa could you give this a test?

vrunoa commented 8 years ago

@adam-lynch if we change platform(arch) type to list, we can only select one platform(arch) at a time, and this is not the idea, since a user may want to create more than one release at a time. I would still consider to left the platform(arch) type to checkbox and set a default value in case the user press Enter without selecting any of them. What do you think ?

adam-lynch commented 8 years ago

@vrunoa I assumed that the user would just select all for the arch if they wanted both. Unless you meant they might want mac & windows, 64-bit (for example).

vrunoa commented 8 years ago

@adam-lynch exactly. Maybe some user just want to build for windows and mac avoiding linux, or any combination that just includes 2 platforms. Setting the input to a list type would remove this flow from the module. I believe the best solution for this case would be set the user platform(arch) as default. Also add a validation, throw an error when platform or arch os not selected. Let me know if you would like to implement this, otherwise I'll add this implementation.

adam-lynch commented 8 years ago

Ok. A default would be better than nothing but still would be pretty annoying if you thought you selected a certain arch and it defaulted to another. So maybe there needs to be a message something like "press space to select, enter to move to next step"?

vrunoa commented 8 years ago

@adam-lynch good idea. We can add this to the current message for platform(arch) selection.