UseAllFive / Method-Studios

2 stars 0 forks source link

Form validation for jobs application #154

Closed bretmorris closed 11 years ago

bretmorris commented 11 years ago

When trying to submit a job application form without all the required fields it may appear to the user that nothing happened. This is because the page refreshes with the word "required" written in white text above fields that have not been filled out. This can be very easy to miss. Also, the required text does not appear over the file upload fields even if those are left blank.

So a couple of things have to happen:

  1. Needs to be more obvious that there are errors on fields that have not been filled out
  2. Need to add error message to file upload fields if left blank upon submission.

Melissa requested the following*:

Make a warning appear in blue saying '*Please submit details for all required fields' should someone try to submit without doing so

*maybe it makes more sense, and would be much simpler to just make the required text red and then tackle #2 above

bretmorris commented 11 years ago

@levib maybe it makes more sense, and would be much simpler to just make the required text red and then tackle #2 above. Can you reach out to client? This allows them to see which fields are missing.

bretmorris commented 11 years ago

Hey @danielornelas looks like levi is good with just changing the color of the required text. This I can do. But can you help me out with point 2.

Need to add error message to file upload fields if left blank upon submission.

bretmorris commented 11 years ago

Revision 793 takes care of everything except for https://github.com/UseAllFive/Method-Studios/issues/154#issuecomment-11070209

bretmorris commented 11 years ago

Improved styles for required error & file input w/ Revision 796.

danielornelas commented 11 years ago

Validation now requires file upload of Resume w/ Revision 797