search

UseAllFive / tc-documentation

3 stars 0 forks source link

Settings > Remove Photo button does not work #278

Closed jjkaye closed 13 years ago

jjkaye commented 13 years ago

Mac Firefox 3.6.12 & Safari 5.0

gabehayes commented 13 years ago

It's not a button, it's actually a checkbox. Clicking it makes the button turn orange to identify the button as selected. You then have to save your changes for the photo to be removed.

Maybe we can toggle text on click that says something like "You must save your settings for the photo to be removed..."

jjkaye commented 13 years ago

What if Remove Photo acted as a submit button and just save the form changes and also removed the photo. Would it be strange for it to act like that?

gabehayes commented 13 years ago

Matt, I'd like to get your opinion on this. I think triggering a form submit on click could solve this, except we need to note that any form changes made would be saved, not just removing the photo.

Any alternate solutions you could propose, Matt?

m14t commented 13 years ago

making this check the box and also submitting the entire form is fine by me.

colinjschmidt commented 13 years ago

Done. Committed Rev #908. - just submitting form on button click, so page reloads and image is gone!