Need close X on alert messaging

UseAllFive / tc-documentation

3 stars 0 forks source link

Need close X on alert messaging #283

Closed jjkaye closed 13 years ago

jjkaye commented 13 years ago

Dashboard messages in general: there used to be Close buttons in the upper right corner: these were good. Did they go away? We’d like to give users the option to close these.

m14t commented 13 years ago

If they close them, should they come back on refresh?

I really don't think having a close box on the message saying their account will be deleted if they don't follow this action is a good idea.

jjkaye commented 13 years ago

Well...

this might add a level of complexity but could some actions be dismissible and others not?

colinjschmidt commented 13 years ago

@jjkaye - What are we doing about this one? Is this high priority still?

jjkaye commented 13 years ago

@colin99, I was hoping @m14t could provide some additional detail about possibly setting up a conditional to make certain messages dismissible and others persistent.

m14t commented 13 years ago

@jjkaye what messages would you want to be dismissable? Seems that currently we have two types of messages.

These dashboard messages
- For unconfirmed accounts
- For public profiles
"Flash" messages, that show up and fade away automatically.

Of these the only message I think we should possibly hid is the Public Profile notification. If you want to do this then I think the best way to do it would be to have JS hide it on the click of the 'X' and then set a cookie. Then modify the template to not show it if that cookie is set.

jjkaye commented 13 years ago

@m14t the only message I want to "stick" is the unconfirmed account message, all other messages can and should disappear automatically or on user request. Make sense?

m14t commented 13 years ago

Sure.

@colin99 / @gabehayes : you can use $sf_request->getCookie('cookie-name') in your template to get the cookie you set with JS.

colinjschmidt commented 13 years ago

On it.

colinjschmidt commented 13 years ago

@jjkaye - Is this style ok for the close button. Using same icon as close button in popup.

http://ss.picturechaos.com/v1/view.php?i=4dc07f300730e

Also, what do you think about revising the text in the "Account Unconfirmed" notification so that text doesn't wrap. Can you provide new, shorter copy for that notification?

jjkaye commented 13 years ago

Can we just do a simple orange 'x' like I had in the mockup?

colinjschmidt commented 13 years ago

Sure.

colinjschmidt commented 13 years ago

Finished: Commited Rev #919.