search

UseAllFive / true-visibility

Checks if a DOM element is truly visible
http://useallfive.com/javascript-tool-detect-if-a-dom-element-is-truly-visible/
Other
109 stars 26 forks source link

False negatives/false positives #8

Open alanhkarp opened 10 years ago

alanhkarp commented 10 years ago

I am writing a password management tool that should only fill password fields if they are visible. On the following sites isVisible reports that password field are not visible, but they can be seen on the page:

linkedin.com, wordpress.com, outbrain.com, amazonaws.com, hulu.com, wikihow.com, webmd.com

On none of these sites is the password field in an iframe. In most but not all of these cases, the problem is with the overlap test.

On fiverr.com isVisible reports that password fields are visible when they can't be seen on page.

jasonfarrell commented 10 years ago

Can you give me the page that you're trying it on, and the password's element selector?

alanhkarp commented 10 years ago

You can get them yourself.

linkedin.com: You'll see two password fields on the page. isVisible finds the one at the top but not the one at the bottom. wordpress.com: Click login . isVisible says the password field on that page is hidden outbrain.com: Click login . isVisible says none of the three password fields should be visible amazonaws.com: Click login and select any of the options. isVisible returns false on the password field hulu.com: Click login . Password field reported not visible wikihow.com: isVisible says the password field isn't visible webmd.com: Click the login link then click the userid field to keep the popup open. isVisible says the password field isn't visible fiverr.com: Click login. isVisible reports as visible a password field that isn't in the viewport

Alan Karp

On Tue, Oct 7, 2014 at 3:03 PM, Jason Farrell notifications@github.com wrote:

Can you give me the page that you're trying it on, and the password's element selector?

— Reply to this email directly or view it on GitHub https://github.com/UseAllFive/true-visibility/issues/8#issuecomment-58270598 .