Support more events - Githubissues

UseMuffin / Footprint

CakePHP plugin to allow passing currently logged in user to model layer.

MIT License

95 stars 23 forks source link

Support more events #45

Closed ypnos-web closed 7 years ago

ypnos-web commented 7 years ago

FootprintBehavior now supports all events with arguments:

Event, Query, ArrayObject
Event, EntityTrait, ArrayObject

This includes the previously missing Model.beforeRules event. Solution for #40

ADmad commented 7 years ago

Current failing test has been fixed, please rebase.
Remove the FootPrintBehaviorTest2 and add your new test cases in FootPrintBehaviorTest itself.
Please follow CakePHP's coding starndard. There are numerous violations https://travis-ci.org/UseMuffin/Footprint/jobs/215928002

ypnos-web commented 7 years ago

@ADmad Please let me know how to incorporate the test for Model.beforeRules in the FootprintBehaviorTest without messing it up. Just including it into the config would clash with the test for Model.beforeSave.

ypnos-web commented 7 years ago

So I guess we are set?