UseMuffin / Footprint

CakePHP plugin to allow passing currently logged in user to model layer.

MIT License

95 stars 23 forks source link

Add Plugin Manifest #69

Closed JacobAGTyler closed 4 years ago

JacobAGTyler commented 4 years ago

This should enable the correct loading of the plugin, long term and to preempt the warning coming in 4.2. See discussion on CakePHP/CakePHP 4.1.2 bug fix in the long term. CakePHP #14891

ADmad commented 4 years ago

Changes for Cake 4 need to target the cake-4.x branch. master is for Cake 3.x and I don't intend to make new releases for it unless we hit an actual bug :)

JacobAGTyler commented 4 years ago

Changes for Cake 4 need to target the cake-4.x branch. master is for Cake 3.x and I don't intend to make new releases for it unless we hit an actual bug :)

No problem, sorry wasn't looking at the branch. Just getting PHPBF running and I'll add that to the commit too.

ADmad commented 4 years ago

No worries, just rebase your bugfix branch on top of the cake-4.x branch.

JacobAGTyler commented 4 years ago

Sorry that was more of a faff than I intended. Should have just pulled it down from the beginning. Should both be all sorted now. Thanks for reviewing. :)

codecov[bot] commented 4 years ago

Codecov Report

Merging #69 into cake-4.x will not change coverage. The diff coverage is n/a.

@@             Coverage Diff             @@
##             cake-4.x      #69   +/-   ##
===========================================
  Coverage       92.91%   92.91%           
  Complexity         58       58           
===========================================
  Files               3        3           
  Lines             127      127           
===========================================
  Hits              118      118           
  Misses              9        9