UseMuffin / Footprint

CakePHP plugin to allow passing currently logged in user to model layer.
MIT License
95 stars 23 forks source link

CakePHP 5 changes #84

Closed LordSimal closed 1 year ago

LordSimal commented 1 year ago

This should go into a separate cake5 or 4.x branch.

codecov[bot] commented 1 year ago

Codecov Report

Merging #84 (c3a3026) into cake-5 (9a2d09f) will increase coverage by 6.24%. The diff coverage is 71.42%.

@@             Coverage Diff              @@
##             cake-5      #84      +/-   ##
============================================
+ Coverage     69.23%   75.47%   +6.24%     
+ Complexity       46       43       -3     
============================================
  Files             4        4              
  Lines           117      106      -11     
============================================
- Hits             81       80       -1     
+ Misses           36       26      -10     
Impacted Files Coverage Δ
src/FootprintPlugin.php 0.00% <0.00%> (ø)
src/Middleware/FootprintMiddleware.php 0.00% <0.00%> (ø)
src/Event/FootprintListener.php 87.50% <100.00%> (-1.39%) :arrow_down:
src/Model/Behavior/FootprintBehavior.php 94.28% <100.00%> (+0.08%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

ADmad commented 1 year ago

One final change, can you please rename Plugin class to FootprintPlugin.

ADmad commented 1 year ago

Why did the rename start throwing stan errors, it was green before 😆

LordSimal commented 1 year ago

what the....

ADmad commented 1 year ago

Muchas gracias.

LordSimal commented 1 year ago

De nada.