search

UserNobody14 / tree-sitter-dart

Attempt to make a tree-sitter grammar for dart
MIT License
59 stars 36 forks source link

feat: allow spell comments #35

Closed sidlatau closed 1 year ago

sidlatau commented 1 year ago

This will enable spell-checking only for comments in code. Context: https://github.com/neovim/neovim/pull/19419

akinsho commented 1 year ago

@sidlatau the highlighting that neovim uses does not come from this repository. It comes from a custom highlights.scm that I contributed a while ago. So whilst this change might be beneficial here, although I think it's not since the directive is specific to neovim. You will need to actually contribute those changes over in the nvim-treesitter repository in order to see them in neovim

sidlatau commented 1 year ago

Oh, yes, I assumed that after this I will not need to add this to my dotfiles. I saw you added these to your dotfiles (https://github.com/akinsho/dotfiles/blob/nightly/.config/nvim/queries/dart/highlights.scm). But logically it should be set somewhere else upstream. But now I am not sure where 🤔 Should I close this PR?

akinsho commented 1 year ago

@sidlatau I had meant to upstream that at some point it should be added to nvim-treesitter. There are queries there and it should be added to the highlights.scm

sidlatau commented 1 year ago

Ok, thanks for explanation @akinsho, I will close this PR then, because it will not achieve my ecpected results.