search

UserOfficeProject / issue-tracker

Shared place for features and bugs from all collaborators.
0 stars 0 forks source link

Make email event handler configurable by environment #106

Closed simonfernandes closed 3 years ago

simonfernandes commented 3 years ago

Related to https://github.com/UserOfficeProject/stfc-user-office-project/issues/71

Currently, the email service (responsible for how emails are sent - SMTP in our case) is configurable by environment, but the actual event handler that decides when emails are sent, who they're sent to, and what the email content is, is not. We should make this configurable to enable STFC and ESS to individually customise outgoing emails.

As mentioned by Fredrik in sprint planning, this is probably a good use for the tsyringe dependency injection framework.

TickleThePanda commented 3 years ago

Let's see what happens with #95 before we move ahead with this.

TickleThePanda commented 3 years ago

We need to clarify if we actually will trigger any of the events that currently exist and if we need to prevent these from happening.

If we don't, we can push this to a later milestone.