Proposals can be cloned and submitted with instruments that aren't on the call - Githubissues

UserOfficeProject / issue-tracker

Shared place for features and bugs from all collaborators.

0 stars 0 forks source link

Proposals can be cloned and submitted with instruments that aren't on the call #1192

Open ACLay opened 1 week ago

ACLay commented 1 week ago

What is the problem and why is it a problem

For ISIS direct 2025_1 we excluded the LET instrument. An old proposal that used that instrument was cloned to create 2510291, and it was able to submit with that invalid instrument.

I think @TCMeldrum can fill in this, but there seem to be some broken links as a result of this, causing the proposal to be unqueriable in our downstream software?

Steps to reproduce (if it's a bug).

TCMeldrum commented 1 week ago

After some investigation of what happened here is what I think happened, some of this is STFC specific so anyone else reading this I'm sorry.

A user cloned a proposal from a old call where they had selected a instrument Let which was not being offered on this call
The system allowed this proposal to be submitted (This is the bug)
The automatic instrument assignment didn't happen as the instrument is not on the call so this proposal ended up submitted but with no instrument assigned to it

STFC Specific:

Allocations then tried processing the proposal but since no instrument was assigned to the proposal, allocations defaulted on looking for an instrument selection question
This then failed as the call does not use these questions any more, so gave us an error saying template malformed and required answer not available.

In conclusion, the bug in UOP was that a proposal can be submitted with an instrument picker answer that is invalid.

For the allocations side this seems like the behaviour is not quiet right but idk what to do about it @ACLay