search

UserOfficeProject / issue-tracker

Shared place for features and bugs from all collaborators.
0 stars 0 forks source link

Generic templates split across pages in the proposal PDF #283

Closed simonfernandes closed 2 years ago

simonfernandes commented 3 years ago

In the proposal PDF, generic template answers are displayed in a grid format:

Your image title

All of the information in a box should be kept on the same page so that it is not split between pages. In the example below, the third grid box should be displayed on its own page:

Your image title

I think this is because the CSS rule page-break-inside: avoid; isn't being respected. I tried various things with Bootstrap columns and rows, and also overriding that by using flex. The only way I could get it to work was with a single column, not multiple. It seems to be an older CSS rule and the only possible solution I could find was to put the layout in a table. I guess this would be fine since it's all rendered to PDF anyway, but I think it would require additional logic of when to insert new rows, which I wasn't sure was the right route.

WhittyPM commented 3 years ago

@TickleThePanda @simonfernandes is this a bug fix needed for release?

simonfernandes commented 3 years ago

@WhittyPM It's lower priority so not needed for release. I've cleared the milestone but I'm not sure which it should come under. Possibly the next proposal release?

WhittyPM commented 3 years ago

@simonfernandes thank you. I have updated the milestone. I don't think we want to be changing the FAP pdfs during LSF round, but maybe I am wrong :)

TickleThePanda commented 2 years ago

No longer a problem as we have manual templates.