UserTeemu / SunIRL

Now you can see the real life sun position in Minecraft!
GNU General Public License v3.0
2 stars 0 forks source link

Permanently Stuck At Noon #1

Open TheBrokenRail opened 4 years ago

TheBrokenRail commented 4 years ago

The server in question is the ModFest 1.16 (doDaylightCycle is disabled) showcase server. When connected to the server with the mod loaded I saw two suns, and when the time is set to night via commands, the suns still won't move, the sun also won't move when the game is loaded without SunIRL.

TheBrokenRail commented 4 years ago

Without SunIRL: 2020-07-02_18 33 50

TheBrokenRail commented 4 years ago

With SunIRL: 2020-07-02_18 36 22 2020-07-02_18 36 30

TheBrokenRail commented 4 years ago

Both photos were taken while the time was set to noon, but it is the same behavior when the time is set to night.

TheBrokenRail commented 4 years ago

OK, all of a sudden it work now. This issue seems hard to reproduce. Except the two suns, that is easy.

TheBrokenRail commented 4 years ago

I seem to only have 1 sun now too.

UserTeemu commented 4 years ago

If you'll visit the void (at y 0.5 for example), you'll see that the other sun most likely is the moon, but too bright (when you're in the void the brightness is about normal). I will be looking at the brightness later.

Reason for the sun not moving could be in the settings (it's called Use MC time in calculations). You can access the settings from modmenu.

UserTeemu commented 4 years ago

Correction: y = -1.5

TheBrokenRail commented 4 years ago

It seems to be working now for some reason? Hmm, my guess is that it doesn't do any calculation when doDaylightCycle is false, even if time is set manually, I don't know anything about the code, so that may be completely wrong though.

UserTeemu commented 4 years ago

The calculations don't read the value for the gamerule. It's a loop registered to ClientTickCallback and the calculation runs every X ticks (adjustable from the settings).