UsergeTeam / Userge-Plugins

Plugins for Userge
https://userge.tech
GNU General Public License v3.0
135 stars 327 forks source link

ffmpeg: Re-write the module #236

Closed yshalsager closed 2 years ago

yshalsager commented 2 years ago

Changes:

New commands

pep8speaks commented 2 years ago

@yshalsager, Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2022-02-17 09:58:25 UTC
rking32 commented 2 years ago

Hi @yshalsager, Thanks for your hard work and sorry for the delay. Seems like it would be very useful and you have added so many methods. We will check this asap :)

Harsh-br0 commented 2 years ago

There's no need to use ffmpegsave command anymore. All module commands will work with telegram files, local files, and direct links.

@yshalsager hey there , seems we need that save cmd since we can't have any visual feedbacks like in conventional android apps that first visualise the changes and exports them in single attempt , but here we need to do hit-and-trial in some scenarios like setting resolutions , etc so to optimise performance , the cmd may gradually affect it by saving last media locally. So , Can you please evaluate the scenario and present your views further , thanks

yshalsager commented 2 years ago

There's no need to use ffmpegsave command anymore. All module commands will work with telegram files, local files, and direct links.

@yshalsager hey there , seems we need that save cmd since we can't have any visual feedbacks like in conventional android apps that first visualise the changes and exports them in single attempt , but here we need to do hit-and-trial in some scenarios like setting resolutions , etc so to optimise performance , the cmd may gradually affect it by saving last media locally. So , Can you please evaluate the scenario and present your views further , thanks

I have replaced ffmpegsave function with get_media_path_and_name that utilizes tg_download and url_download from download module (can be replaced with handle_download BTW), so it still visual progress exactly the same way as download module.

Krishna-Singhal commented 2 years ago

I have replaced ffmpegsave function with get_media_path_and_name that utilizes tg_download and url_download from download module (can be replaced with handle_download BTW), so it still visual progress exactly the same way as download module.

I think you are not getting what he is saying, anyways added -d flag to do same thing as he said